feat(policy): migrate policies to Rego v1 syntax #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliconsheep
requested review from
Illedran,
acalm,
gentoomaniac,
kjelljoakim,
krateria and
lonefreak
Illedran
reviewed
May 12, 2025
Comment on lines
-6
to
+8
| input := { | ||
| "resource": { | ||
| "google_compute_firewall": { | ||
| "f1": { | ||
| "name": "f1", | ||
| "source_ranges": ["0.0.0.0/0"], | ||
| "allow": { | ||
| "ports":["22", "5432"] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| test_deny_compute_firewall_unrestricted if { | ||
| inp := {"resource": {"google_compute_firewall": {"f1": { |
Member
There was a problem hiding this comment.
Not sure about this formatting, maybe this and others like it was ported to v1 syntax manually? I would format consistently or just at least we can leave a small comment on this PR for how the porting was done for posterity's sake
Member
There was a problem hiding this comment.
all files were preprocessed with
opa fmt --write --v0-v1
Member
Author
There was a problem hiding this comment.
I'll also copy this comment in the PR description for increased visibility 👌
Illedran
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
As of conftest v0.60.0, the default version of Rego syntax is v1 [1]. This PR updates all policies to use this syntax. Another breaking change came with this version as well (or rather v0.59.0) [2], where hcl2json will consistently use array when using repeated blocks ([3] and [4]). Current (internal) uses are checked for breaking changed. All files were formatted / pre-processed with
opa fmt --write --v0-v1Related Issues
[1] https://github.com/open-policy-agent/conftest/releases/tag/v0.60.0
[2] https://github.com/open-policy-agent/conftest/releases/tag/v0.59.0
[3] open-policy-agent/conftest#1074
[4] open-policy-agent/conftest#1006