Skip to content

Clean up tickets & backfill on failed indexing #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clean up tickets & backfill on failed indexing #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76cecd7
Added direct calls to store on clean up stale data
Relrin Nov 12, 2025
d7a981e
Background clean up for ticket and backfills
Relrin Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions internal/app/frontend/frontend_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,28 @@ func doCreateTicket(ctx context.Context, req *pb.CreateTicketRequest, store stat

err = store.IndexTicket(ctx, ticket)
if err != nil {
// Schedule a ticket deletion on the background
go func() {
ctx, span := trace.StartSpan(context.Background(), "open-match/frontend.cleanupNewTicket")
defer span.End()

err := store.DeleteTicket(ctx, ticket.Id)
if err != nil {
logger.WithFields(logrus.Fields{
"error": err.Error(),
"id": ticket.Id,
}).Error("failed to delete the recently created ticket")
}

err = store.DeleteTicketsFromPendingRelease(ctx, []string{ticket.Id})
if err != nil {
logger.WithFields(logrus.Fields{
"error": err.Error(),
"id": ticket.Id,
}).Error("failed to delete the recently created ticket from pendingRelease")
}
}()

return nil, err
}

Expand Down Expand Up @@ -136,6 +158,20 @@ func doCreateBackfill(ctx context.Context, req *pb.CreateBackfillRequest, store
}
err = store.IndexBackfill(ctx, backfill)
if err != nil {
// Schedule a backfill deletion on a background
go func() {
ctx, span := trace.StartSpan(context.Background(), "open-match/frontend.cleanupNewBackfill")
defer span.End()

err := store.DeleteBackfillCompletely(ctx, backfill.Id)
if err != nil {
logger.WithFields(logrus.Fields{
"error": err.Error(),
"id": backfill.Id,
}).Error("failed to delete the recently created backfill")
}
}()

return nil, err
}
return backfill, nil
Expand Down