-
Notifications
You must be signed in to change notification settings - Fork 1
DisallowPartial option in AssignTickets #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
af5c624 to
aed661d
Compare
|
Note: since you only changed protos, you might need to run |
aed661d to
cacaea5
Compare
Ah ok, thanks! I noticed that a bunch of version numbers change as well: is that something I can/should avoid? 🤔 |
Unfortunately no direct way, its a go thing, the toolchain always tries to update packages/modules. You can rollback or ignore them unless you explicitly updated a go module version. I normally just roll them back. You could but it would require you to pin the versions of all the modules using the replace command which is a lot of work. |
odouglas-es
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! would be nice to have a couple unit tests to validate this, what do you think?
slvmnd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
In many cases, if one assignment fails we want all of them to fail instead of creating a partial match. This PR adds and option all_or_none to the AssignTickets request that, if set, avoids assigning any of the tickets if at least one is not found before starting the assignment.