generated from EmbarkStudios/opensource-template
-
Notifications
You must be signed in to change notification settings - Fork 98
Staging: test fix and features before stable integration #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gwen-lg
wants to merge
62
commits into
EmbarkStudios:main
Choose a base branch
from
gwen-lg:staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update imports.lock
added a corresponding puffin file
added a corresponding puffin file
added a corresponding puffin file
added a corresponding puffin file
…http serialization
this avoid the need of puffin_http and puffin_viewer or to do a manual implementation.
- add test create_frame_writer
- reduce allocation and data copies during (de)serialization. TODO: handle PacketStream
from 0.2
dev-dependencies
The default behavior change to `xdg-portal` for dialog instead of `gtk3`.
with profile_scope and profile_function merker
use a rendez-vous channel this could be useful for issues EmbarkStudios#85 and EmbarkStudios#172
added a corresponding puffin file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't be merged. This is more for a demo, tests and get feedback.
Checklist
Description of Changes
FrameWriterto directly write puffin data in a file (or otherWriteimpl). This can be particularly useful to get profiling data on 'one frame app`.wait_client()fn for puffin_http Server. This avoid lost frames during connection. puffin_http clients can't get firsts frame if they are short #85Related Issues