perf: make filters synchronous #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
Jake-Shadle,
koslib and
markmandel
as code owners
XAMPPRocky
force-pushed
the
ep/sync-filter
branch
from
007df10 to
42361a5
Compare
Member
|
https://github.com/googleforgames/quilkin/blob/7a81ba0016f8c9d4ce9cf4687019b8fb57eb6dd0/src/components/proxy/io_uring_shared.rs#L272-L375 Needs to be changed as well, otherwise it is still spawning tasks and sending messages rather than processing in the loop. |
XAMPPRocky
force-pushed
the
ep/sync-filter
branch
from
a912264 to
1b3153b
Compare
Member
|
Maybe I wasn't clear enough, the tasks should not be spawned at all since those are on the tokio runtime, I think just processing the packet inside the loop itself would maybe make things better since it won't need to context switch out for something that should take a micro/nanoseconds. |
XAMPPRocky
force-pushed
the
ep/sync-filter
branch
from
1b3153b to
1552970
Compare
XAMPPRocky
force-pushed
the
ep/sync-filter
branch
from
1552970 to
ec0668f
Compare
XAMPPRocky
force-pushed
the
ep/sync-filter
branch
from
74fe80b to
ec028d7
Compare
Jake-Shadle
requested changes
Oct 7, 2024
Collaborator
|
Build Succeeded 🥳 Build Id: 5090f5b3-5a9e-48b4-ac68-b5f5b5079d6a The following development images have been built, and will exist for the next 30 days: To build this version: |
Jake-Shadle
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to check whether making the filters synchronous makes a difference to the performance under the new raw io-uring implementation.