Skip to content

perf: Use enum_dispatch over dynamic dispatch #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

perf: Use enum_dispatch over dynamic dispatch #1027

merged 1 commit into from
Nov 21, 2024

Conversation

@XAMPPRocky
Copy link
Member

@XAMPPRocky XAMPPRocky commented Oct 8, 2024

Another perf test to see if how much using enum_dispatch affects performance.

@github-actions github-actions bot added size/xl and removed size/l labels Oct 8, 2024
@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added size/l and removed size/xl labels Oct 8, 2024
@XAMPPRocky XAMPPRocky force-pushed the ep/enum-dispatch branch 5 times, most recently from a00b761 to 7152f34 Compare October 14, 2024 16:10
@github-actions
Copy link

github-actions bot commented Oct 14, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added size/xl and removed size/l labels Oct 14, 2024
@github-actions
Copy link

github-actions bot commented Oct 14, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 14, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 14, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 14, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added size/l and removed size/xl labels Oct 16, 2024
@XAMPPRocky XAMPPRocky force-pushed the ep/enum-dispatch branch 4 times, most recently from bbcf08a to a58e34f Compare October 22, 2024 14:23
@quilkin-bot
Copy link
Collaborator

quilkin-bot commented Oct 23, 2024

Build Succeeded 🥳

Build Id: d0f07da4-c2d9-43c9-9f06-517fbff8f169

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/1027/head:pr_1027 && git checkout pr_1027
cargo build

@XAMPPRocky XAMPPRocky merged commit 9eeb0e8 into main Nov 21, 2024
12 checks passed
@Jake-Shadle Jake-Shadle deleted the ep/enum-dispatch branch November 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@koslib koslib Awaiting requested review from koslib

Assignees

No one assigned

Labels

kind/other size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XAMPPRocky @quilkin-bot @Jake-Shadle