Add support for subscriptions #1296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is adding facilities and tests for subscriptions. Right now it is not hooked up to any I/O, which is intentional as the reason for duplicating some code from upstream corrosion itself was due to the fact it was too closely tied with HTTP, which we may not be using in future PRs.
This moves all of the integration tests into corrosion-tests, renamed from corrosion-utils. The original idea was to have the tests with the actual corrosion crate, but that meant duplication of eg. setup code in the test helper crate instead of just being able to use the code in the corrosion crate in the test helpers.
Resolves: #1291