Account for signedness in memset const pat #1143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes EmbarkStudios#1061 Thanks to LegNeato
JulianKnodt
commented
Apr 12, 2024
| @@ -315,7 +338,7 @@ impl<'a, 'tcx> Builder<'a, 'tcx> { | |||
| } else { | |||
| for index in 0..count { | |||
| let const_index = self.constant_u32(self.span(), index as u32); | |||
| let gep_ptr = self.gep(pat.ty, ptr, &[const_index]); | |||
| let gep_ptr = self.inbounds_gep(pat.ty, ptr, &[const_index]); | |||
There was a problem hiding this comment.
I added this because I assume that const memsets will always be in a valid range, but I'm not sure.
|
Awesome, that was quick!!!! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1061
Thanks to LegNeato for pointing out what was wrong