Allow empty statements in switch

[arturjpv]

Allow empty statements in switch.

[tvandijck]

is there a code example for this?

[arturjpv]

is there a code example for this?

From Pioneer\Script\Pioneer\Constructable\StyleDrivers\GlowingMetalStyleDriver.as

	UFUNCTION()
	private void OnCapabilityEventOccured(const UCapability Capability, const FConstructableCapabilityEvent& EventData)
	{
		if (Capability.AbilityTags.MatchesQuery(AbilityTagQuery))
		{
			switch(EventData.EventType)
			{
				case EConstructableCapabilityEventType::Stop:
					StartFadeOut();
					break;
				default:
			}
		}
	}

	UFUNCTION()
	private void OnCapabilityStateChanged(const UCapability Capability,
	                                      const FCapabilityStateData& StateData)
	{
		if (Capability.AbilityTags.MatchesQuery(AbilityTagQuery))
		{
			switch(StateData.State)
			{
				case ECapabilityState::Preparing:
					StartFadeIn();
					break;
				case ECapabilityState::CoolingDown:
					StartFadeOut();
					break;
				default:
			}
		}
	}

[tvandijck]

that looks like it's just bad code... I wouldn't accept that... people shouldn't check-in nonsense like that.

[arturjpv]

that looks like it's just bad code... I wouldn't accept that... people shouldn't check-in nonsense like that.

I agree it's bad code, but it compiles. And the server code exciser fails to parse it... so it's not even treated as an error. The file is skipped. So this missmatch betwen compiler and "server scope linter" can be bad.

We also have this one in Discovery\GameMode\GameShowEvents\AlienInvasion\AlienInvasionFlyingSaucer.as:

	void ChangeMovementMode(ESaucerMovementMode DesiredMovementMode)
	{
		switch (DesiredMovementMode)
		{
			case ESaucerMovementMode::Stalk:
			{
				CurrentMovementMode = ESaucerMovementMode::Stalk;
				TargetFlySpeed = StalkModeSpeed;
				return;
			}
			case ESaucerMovementMode::Loiter:
			{
				CurrentMovementMode = ESaucerMovementMode::Loiter;
				TargetFlySpeed = LoiterModeSpeed;
				return;
			}
			case ESaucerMovementMode::Boost:
			case ESaucerMovementMode::None:
		}
	}

Thaw will force us to add empty statements for any labeled case statement.

I will try to solve it this same PR... as probably one modification affects the other.

[arturjpv]

that looks like it's just bad code... I wouldn't accept that... people shouldn't check-in nonsense like that.

The other option is two modify all those switch statements to make them good and don't modify the grammar. But then, maybe, we don't notice that people is submitting more code like that in other parts and we have more files skipping checks because of not being able to parse them.

[webbju]

I see your point here @arturjpv. The current code is syntactically valid despite how poor practice it may be. For me this is a 'lgtm' based on the premise that this tool is not a linter, and that this kind of coding style issue should probably be solved with compiler warning flags or other tooling.