Add a way to lint and generate #ifdefs around UEventAPI calls. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturjpv
reviewed
Sep 3, 2025
| var returnData = GetDefaultReturnStatementForScope(parentScope); | ||
|
|
||
| ServerOnlyScopeData newData = new ServerOnlyScopeData( | ||
| ExcisionUtils.FindScriptIndexForCodePoint(Script, simpleDeclaration.Stop.Line, simpleDeclaration.Stop.Column) + 1, |
Member
There was a problem hiding this comment.
I see we are removing these lines and commenting the ShrinkServerScope. I remember doing this correction because of the StartIndex/StopIndex adjustment. Everything behaves ok after removing them?
Collaborator
Author
There was a problem hiding this comment.
no, I'm still working on things, in some very rare cases (like 2 files out of 5000) I end up with double macros... very weird. It's not because of this though.
Member
There was a problem hiding this comment.
Yes, I added the ShrinkServerScope to avoid the double macro problem here. Not sure about the origin of the FindScriptIndexForCodePoint calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Describe your changes here
Related Issues
List related issues here