Skip to content

Conversation

@djc
Copy link
Contributor

@djc djc commented Oct 23, 2025

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Update to latest gix.

@djc djc requested a review from Jake-Shadle as a code owner October 23, 2025 14:24
@djc
Copy link
Contributor Author

djc commented Oct 23, 2025

Okay, this makes gix::ObjectId non-exhaustive, while you currently have a number of irrefutable matches against ::Sha1. It seems useful to start storing a gix::ObjectId internally, but I'm not sure exactly how you might want to pursue that (ValidCacheEntry currently stores a &str that may also represent a sparse index HTTP header value -- might be sensible to use a wrapping enum for that?). Happy to help if you want to outline the desired direction -- also fine if you just want to close this.

@Jake-Shadle Jake-Shadle merged commit ca32787 into EmbarkStudios:main Oct 23, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants