Skip to content

Conversation

@Totodore
Copy link
Contributor

@Totodore Totodore commented Jun 20, 2025

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

The futures crate bring a whole async executor whereas the only things that are used in this lib are :

  • The Future trait which comes from the ̀futures-core lib and also exist in the std lib (MSRV 1.36)
  • The Ready struct which comes from the futures-util lib and also exist in the std lib (MSRV 1.48)
  • The ready macro which comes from the futures-core lib (and can be replaced with match statements).

Currently everything is either available in the std or can be replaced.

It might also be a good idea to define a msrv for this crate.

Related Issues

@Totodore Totodore force-pushed the remove-futures-deps branch from 2a84eea to 3ffed8a Compare June 20, 2025 15:12
@Totodore Totodore changed the title chore(deps): use futures-core rather than futures chore(deps): move futures to dev-deps Jun 20, 2025
@fu5ha fu5ha self-requested a review June 23, 2025 08:17
Copy link
Member

@fu5ha fu5ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this looks like a good change. I suppose this bumps our MSRV to at least 1.48. We don't explicitly document it but probably should, but 1.48 is old enough that I think I'm fine with just going for it.

@fu5ha
Copy link
Member

fu5ha commented Jun 23, 2025

If you could fix the clippy lint and also add a Changelog entry that would be great :)

@Totodore
Copy link
Contributor Author

@fu5ha it seems that there is a flaky test that doesn't pass on windows. I tried to make a fix, it works well on my fork.

@fu5ha
Copy link
Member

fu5ha commented Jun 23, 2025

Nice, thank you! I will tag and publish a release soon

@fu5ha fu5ha merged commit 9161080 into EmbarkStudios:main Jun 23, 2025
6 checks passed
@fu5ha
Copy link
Member

fu5ha commented Jun 23, 2025

Published as 0.5.2

@Totodore Totodore deleted the remove-futures-deps branch June 23, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants