chore(deps): move futures to dev-deps #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
The futures crate bring a whole async executor whereas the only things that are used in this lib are :
Futuretrait which comes from thèfutures-corelib and also exist in the std lib (MSRV 1.36)Readystruct which comes from thefutures-utillib and also exist in the std lib (MSRV 1.48)readymacro which comes from thefutures-corelib (and can be replaced with match statements).Currently everything is either available in the std or can be replaced.
It might also be a good idea to define a msrv for this crate.
Related Issues