Skip to content

Add support for a subset of stock multipreviews #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

rbro112
Copy link
Contributor

@rbro112 rbro112 commented Jun 25, 2024

Android provides some stock multipreview templates as of 1.6.0 source. These also have BINARY retention, preventing our snapshotting from seeing these. This handles a subset of these templates (PreviewLightDark and PreviewFontScale), those whose params are fully supported first-class by us.

Copy link
Contributor Author

rbro112 commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on Graphite Graphite

Copy link

emerge-tools bot commented Jun 25, 2024

📸 Snapshot Test

2 added, 31 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Emerge snapshots sample
com.emergetools.snapshots.sample.debug
1.0 (1) 2 0 0 31 1 ⏳ Needs approval

🛸 Powered by Emerge Tools

@rbro112 rbro112 merged commit 1f20195 into main Jun 25, 2024
9 of 10 checks passed
@rbro112 rbro112 deleted the ryan/add_support_for_a_subset_of_stock_multipreviews branch June 25, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants