keydb: improve liveness and readiness probes

Enapter · Jan 16, 2023 · c578c86 · c578c86
1 parent 085ab10
commit c578c86
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/keydb/Chart.yaml b/keydb/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: keydb
 description: A Helm chart for KeyDB multimaster setup
 type: application
-version: 0.43.1
+version: 0.44.0
 keywords:
 - keydb
 - redis

diff --git a/keydb/templates/cm-health.yaml b/keydb/templates/cm-health.yaml
@@ -10,15 +10,17 @@ data:
 
     set -e
 
+    loading_response="LOADING KeyDB is loading the dataset in memory"
+
     [[ -n "${REDIS_PASSWORD}" ]] && export REDISCLI_AUTH="${REDIS_PASSWORD}"
     response="$(
       timeout -s 3 "${1}" \
       keydb-cli \
         -h localhost \
         -p "${REDIS_PORT}" \
-        ping
+        GET {{ uuidv4 }} # Some random UUID which represents non-existent key
     )"
-    if [ "${response}" != "PONG" ]; then
+    if [ "${response}" = "${loading_response}" ]; then
       echo "${response}"
       exit 1
     fi
@@ -34,9 +36,9 @@ data:
       keydb-cli \
         -h localhost \
         -p "${REDIS_PORT}" \
-        ping
+        PING
     )"
-    if [ "${response}" != "PONG" ] && [[ ! "${response}" =~ ^.*LOADING.*$ ]]; then
+    if [ "${response}" != "PONG" ]; then
       echo "${response}"
       exit 1
     fi