Support passing byte_array into crypto functions #1368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to perform the existing crypto functions using both
byte_array
keys and values. I needed this for signing a HTTP request to access an AWS S3 bucket, which works with this modification.Note that I also needed the following code to convert the returned hex string to a byte array:
It could be helpful to add some
hex_string_to_ba()
function to provide this functionality out of the box, or add some option to make the hmac functions return a byte array instead of a hex string. If this is the case, issues should be created for those feature requests.