Move impl init/deinit to implementation test base class #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyCailin
reviewed
Jun 30, 2025
src/test/java/com/laytonsmith/testing/AbstractImplementationTest.java
Outdated
Show resolved
Hide resolved
Move `Implementation.setServerType(Implementation.Type.TEST);` and `StaticTest.InstallFakeServerFrontend();` from many test classes to `AbstractImplementationTest` and use that as parent class of those classes. Fixes individual tests failing in the IDE and occasional test failures in the automated Linux build.
Pieter12345
force-pushed
the
impl-test-base-class
branch
from
dc8d92b to
a18cf47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
Implementation.setServerType(Implementation.Type.TEST);andStaticTest.InstallFakeServerFrontend();from many test classes toAbstractImplementationTestand use that as parent class of those classes.Fixes individual tests failing in the IDE and occasional test failures in the automated Linux build.