Skip to content

[Bukkit] Warn on version mismatch #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

me4502
Copy link
Member

@me4502 me4502 commented Jul 16, 2025

This PR warns when a version mismatch occurs, rather than completely failing. In cases where the adapter is unable to load, it'll still outright fail- so this is more for cases like recently where 1.21.6, 1.21.7, and 1.21.8 have released in a monthly cadence without binary incompatibilities between them. Theoretically the 1.21.6 version can load on 1.21.8, and this change would allow it, albeit with a warning.

The warning specifies that it hasn't been tested, and issues might occur.

@me4502 me4502 requested a review from a team as a code owner July 16, 2025 10:49
@me4502 me4502 merged commit 9164c46 into version/7.3.x Jul 17, 2025
5 checks passed
@me4502 me4502 deleted the chore/warn-rather-than-fail branch July 17, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants