Add caching for data fetched from MongoDB #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds caching for data from MongoDB. To do this efficiently, we do not immediately decode the BSON we receive from MongoDB, since we may want to have the binary data to store it in Redis. We still need to serialize this data, since we are dealing with a list of BSON objects. To do this, we use pickle. We re-use the existing Redis connection that we already have. If this code is run with different Python versions, they must use the same pickle versions. Otherwise, they may not share the same cache.
MongoMock does not implement returning raw BSON docs. Temporarily comment out datalaoder tests until a fix or workaround is found
kamaldodiya
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds caching for data from MongoDB. To do this efficiently, we do not immediately decode the BSON we receive from MongoDB, since we may want to have the binary data to store it in Redis. We still need to serialize this data, since we are dealing with a list of BSON objects. To do this, we use pickle.
We re-use the existing Redis connection that we already have.
If this code is run with different Python versions, they must use the same pickle versions. Otherwise, they may not share the same cache.