Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paralogues plugin: install ensembl-compara #1745

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Aug 20, 2024

Changelog

  • Add ensembl-compara in INSTALL.pl
    • Required to create annotation for Paralogues plugin: ENSVAR-6290
    • Propagates to Docker image, as expected
  • Build Docker image from context
    • Instead of remotely downloading Docker image, ensembl-vep repo is obtained from context (allowing us to easily test changes)
  • Fix Docker build warnings
    • Change deprecated ENV var 2 to ENV var=2
    • Change to uppercase AS in FROM ubuntu:22.04 as builder

Documentation

Testing

  1. Build Docker image inside the ensembl-vep repo1:

    docker build . -t vep-compara -f docker/Dockerfile
    
  2. Test if the ensembl-compara repo works by creating the Paralogues plugin annotation:

    docker run vep-compara \
      vep --id "4 89828156 rs201106962 A C" \
          --database --db_version 112 --force \
          --plugin Paralogues,clnsig=ignore
    

Footnotes

  1. Building the Docker image in the docker folder won't allow to access files from the parent directory. These changes should work on the automatic build in GitHub Actions because it already takes into consideration the repo as the context: https://github.com/Ensembl/ensembl-vep/blob/main/.github/workflows/docker.yml#L43-L47

@nuno-agostinho nuno-agostinho changed the title Add ensembl-compara to INSTALL.pl and Docker image Paralogues plugin: add ensembl-compara Aug 20, 2024
@nuno-agostinho nuno-agostinho changed the title Paralogues plugin: add ensembl-compara Paralogues plugin: install ensembl-compara Aug 20, 2024
@likhitha-surapaneni likhitha-surapaneni self-assigned this Aug 20, 2024
Copy link
Contributor

@likhitha-surapaneni likhitha-surapaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks @nuno-agostinho

@likhitha-surapaneni likhitha-surapaneni merged commit 9014c51 into Ensembl:postreleasefix/113 Aug 28, 2024
1 check passed
@likhitha-surapaneni
Copy link
Contributor

Merged to main and release/113

@nuno-agostinho nuno-agostinho deleted the add/compara-install branch August 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants