-
Notifications
You must be signed in to change notification settings - Fork 53
2025-06-02-RC2 #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
2025-06-02-RC2 #1631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just briefly looking at the diffs I found a few things that should probably be investigated.
@@ -27824,6 +27916,7 @@ synonym: "Metazoan-associated environment" EXACT [] | |||
is_a: ENVO:01001000 ! environmental system determined by an organism | |||
intersection_of: ENVO:01000254 ! environmental system | |||
intersection_of: RO:0002507 NCBITaxon:33208 ! determined by Metazoa | |||
relationship: BFO:0000050 NCBITaxon:33208 ! part of Metazoa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds wrong to me. How is an animal associated environment part of Metazoa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have always said this, for better or worse, it's just apparent now there is a standardized relaxation step. The right place to fix this is RO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand. How can an environment be "part of metazoa" - you mean to say that conceptual, a taxon is an environment?
|
||
<!-- http://purl.obolibrary.org/obo/ENVO_03620012 --> | ||
|
||
<owl:Class rdf:about="http://purl.obolibrary.org/obo/ENVO_03620012"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its weird to have all these EMPTY class declarations in the ENVO base files.. Why are these here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because someone put them there :-)
grep 03620012 envo-edit.owl
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03620012>))
not 100% sure what to do with these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they dont have a history I would probably suggest we delete them but in any case its a bit weird how they passed QC
<!-- http://purl.obolibrary.org/obo/PATO_0001486 --> | ||
|
||
<owl:Class rdf:about="http://purl.obolibrary.org/obo/PATO_0001486"> | ||
<rdfs:subClassOf rdf:resource="http://purl.obolibrary.org/obo/PATO_0000011"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are PATO axioms in base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks I'll look into these tomorrow
No description provided.