refactoring, add participants to sequence diagram, resolves #47 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Icaceadcb1468ae5ab455eaed611cf9597b6574ec
Godsmith
approved these changes
Mar 21, 2025
Change-Id: I35a6edb478cc634822ea840e2d996945de979707
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Change-Id: I33ee850da5c91a041dff11d93b684c61588910df
vareb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored into 3 files.
Improved diagram type checker that activates correct handlers.
First handler for sequence backgrounds that gets x coordinates of the click relative to the svg.
Next:
Fix so that if we change to another diagram type the handlers for the old one are deactivated
Create a model for keeping track of participants and their coordinates.
Create "addParticipant" endpoint that adds a participant at the correct position