Skip to content

fixed error where level in indentation went below 0, resolves #52 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

fixed error where level in indentation went below 0, resolves #52 #53

merged 2 commits into from
Apr 8, 2025

Conversation

vareb
Copy link
Contributor

@vareb vareb commented Apr 2, 2025

Change-Id: I55cc81a6295b7d7f53aa12f5beaf761609b57cf4

@vareb
fixed error where level in indentation went negative, resolves #52
1c99c52 
Change-Id: I55cc81a6295b7d7f53aa12f5beaf761609b57cf4
@vareb vareb changed the title fixed error where level in indentation went negative, resolves #52 fixed error where level in indentation went below 0, resolves #52 Apr 2, 2025
@vareb vareb requested a review from Godsmith April 2, 2025 18:08
Godsmith
Godsmith requested changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@Godsmith Godsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm going to be a bit annoying and request that you reproduce the issue with a test case and commit this as part of this pull request as well, as that is best practice when fixing a customer-facing bug. (-:

@vareb
test case for #52
21fe63f 
Change-Id: I26e824518b5ab4a9ad288f73bf2d8baf2b60bc8f
@Godsmith Godsmith merged commit 95ba2ee into main Apr 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Godsmith Godsmith Godsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vareb @Godsmith