Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Use DeclarationName in structural eq #545

Open
wants to merge 1 commit into
base: ctu-clang7
Choose a base branch
from
Open

Use DeclarationName in structural eq #545

wants to merge 1 commit into from

Conversation

martong
Copy link

@martong martong commented Nov 28, 2018

I realized that structural eq does not handle some cases properly.

[  FAILED  ] 4 tests, listed below:
[  FAILED  ] StructuralEquivalenceFunctionTest.NotEqualLiteralOperators
[  FAILED  ] StructuralEquivalenceCXXMethodTest.DifferentClasses
[  FAILED  ] StructuralEquivalenceCXXMethodTest.NotEqualConstructors
[  FAILED  ] StructuralEquivalenceCXXMethodTest.NotEqualDestructors

@martong
Copy link
Author

martong commented Nov 29, 2018

Unfortunately this seems to introduce more structural eq errors.
http://ci2.codechecker.gic.ericsson.se:8080/job/ctu_pipeline_clang7/44/

@martong
Copy link
Author

martong commented Dec 3, 2018

Perhaps it is better to put this on hold until we fix some other ODR issues.

@martong martong added the Experimental We still don't know whether this PR will be needed or not. label Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gamesh411 gamesh411 Awaiting requested review from gamesh411

@balazske balazske Awaiting requested review from balazske

Assignees
No one assigned
Labels
Experimental We still don't know whether this PR will be needed or not.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martong