Skip to content

Addition of Gitlab authentication. #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Addition of Gitlab authentication. #4624

wants to merge 6 commits into from

Conversation

@feyruzb
Copy link
Collaborator

@feyruzb feyruzb commented Jul 10, 2025

Added the following:

  • Gitlab OAuth template.
  • Gitlab configuration file section.
  • Documentation regarding username selection options of Gitlab.

@feyruzb feyruzb self-assigned this Jul 10, 2025
@feyruzb feyruzb added enhancement 🌟 documentation 📖 Changes to documentation. python Pull requests that update Python code (used by DependaBot) labels Jul 10, 2025
@feyruzb feyruzb force-pushed the provider-gitlab-addition branch from 2ab1fb7 to 6a19711 Compare July 10, 2025 11:48
@LorandMarton
Copy link

LorandMarton commented Jul 14, 2025 •
edited
Loading

Hi! Thanks for adding support for GitLab authentication - much appreciated!

Quick question: Will this also work with self-hosted GitLab instances? If not, would it be possible to make the template configurable (e.g., allowing a custom domain) to support self-hosted GitLab as well?

@feyruzb
Copy link
Collaborator Author

feyruzb commented Jul 14, 2025

Hi! Thanks for adding support for GitLab authentication - much appreciated!

Quick question: Will this also work with self-hosted GitLab instances? If not, would it be possible to make the template configurable (e.g., allowing a custom domain) to support self-hosted GitLab as well?

Hello, current configuration supports variables overriding, so if you specify variables mentioned below according to your custom GitLab instance in server_config file, it should work.

  • client_id
  • client_secret
  • authorization_url
  • token_url
  • user_info_url

It should look, like this:

image

@feyruzb feyruzb linked an issue Jul 17, 2025 that may be closed by this pull request
OAuth addition of Gitlab authentication #4626
Open
@lom279
Copy link

lom279 commented Nov 12, 2025 •
edited
Loading

@bruntib @dkrupp @vodorok , this GitLab auth addition looks very useful - could it be considered for the next release?

bruntib
bruntib requested changes Nov 15, 2025
View reviewed changes
web/server/codechecker_server/api/authentication.py Outdated
else:
username = user_info.get("mail")
elif template == "gitlab/v1":
print(user_info)
Copy link
Contributor

@bruntib bruntib Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this print.

Copy link
Collaborator Author

@feyruzb feyruzb Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

web/server/codechecker_server/api/authentication.py Outdated
if username_key == "username":
username = user_info.get("preferred_username")
elif username_key == "email":
print(user_info)
Copy link
Contributor

@bruntib bruntib Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this print.

Copy link
Collaborator Author

@feyruzb feyruzb Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@feyruzb feyruzb requested a review from bruntib November 19, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkrupp dkrupp Awaiting requested review from dkrupp dkrupp is a code owner

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@feyruzb feyruzb

Labels

documentation 📖 Changes to documentation. enhancement 🌟 python Pull requests that update Python code (used by DependaBot)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OAuth addition of Gitlab authentication

4 participants

@feyruzb @LorandMarton @lom279 @bruntib