Add argument to set temporary directory during CodeChecker store #4668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furtib
force-pushed
the
store_tmp_dir_loc
branch
from
a02c61d to
484affe
Compare
furtib
force-pushed
the
store_tmp_dir_loc
branch
2 times, most recently
from
5c31813 to
03030da
Compare
Author
|
A flowchart for the selection of the temporary zipfile location: 
|
Szelethus
reviewed
Oct 7, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Sorry, forgot the click "submit review"
furtib
force-pushed
the
store_tmp_dir_loc
branch
from
c595333 to
333c7da
Compare
Szelethus
reviewed
Oct 7, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Reflecting on our conversation yesterday, I think the term "temp" is way too ambigous. How about we call the flag --zip_dir, the variable that handles it same etc?
Author
In my opinion, it would be more fitting to name it |
furtib
force-pushed
the
store_tmp_dir_loc
branch
from
1e05620 to
1659f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
When working on Bezel, we encounter a situation where the result files are placed into a read-only folder. By default,
CodeChecker storecreates a temporary directory for zipping the results before sending them to the server. This directory cannot be created in a read-only folder, causing CodeChecker to crash.What:
This pull request adds an extra command-line argument,
--temp_dir, to theCodeChecker storecommand, which specifies where temporary files should be created. When this argument is not set, it continues to use the previous implementation.Fixes: #4601