-
Notifications
You must be signed in to change notification settings - Fork 440
Add labels for new checkers between 6.26.2 and 6.27.0-rc1 #4695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
My suggestion for this categorisation takes the following result-counts into account. |
|
Note, that I have not considered which checkers are related to SEI-Cert rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I am leaning to enable more checks by default.
I would enable for example almost all compiler warnings that are enabled by default anyway.
Please don't forget to include the checker in the sensitive profile too if you add it to the default profile (as sensitive includes default).
| "google-runtime-float": [ | ||
| "doc_url:https://clang.llvm.org/extra/clang-tidy/checks/google/runtime-float.html", | ||
| "profile:extreme", | ||
| "severity:MEDIUM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably low. a portability check
713f295 to
b8132d7
Compare
dkrupp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I have updated all the checkers in the default profile to also be included in the sensitive and extreme. |
b8132d7 to
d6157e9
Compare
No description provided.