Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Aug 4, 2025

Why: We want to test our rules on real-world examples
What: Added a single FOSS project to the CI pipeline

see issue: #20

Note:
The goal is to build a robust test suite in small steps.

Depends on:
#62

@furtib furtib self-assigned this Aug 11, 2025
@furtib furtib added enhancement New feature or request CI 📦 labels Aug 11, 2025
@furtib furtib requested a review from Szelethus August 13, 2025 11:16
@furtib furtib force-pushed the ci_foss_single branch 4 times, most recently from 58c6949 to 1aaea19 Compare August 19, 2025 08:56
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is ripe for rebase.

@furtib furtib requested a review from Szelethus August 29, 2025 13:26
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start!

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks great. How do the followup patches look like? A python-style unit test? Is that was #16 is supposed to do?

@furtib
Copy link
Contributor Author

furtib commented Sep 3, 2025

The follow-up patches look somewhat like #72, #73 and #74

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Its pretty troublesome to review the other patches with this initial one not being in, and I don't see what else we could change on this. Lets push it!

@Szelethus Szelethus merged commit cdb2f61 into Ericsson:main Sep 4, 2025
4 checks passed
furtib added a commit that referenced this pull request Sep 15, 2025
Why:
We want to test on open source projects. We want to be able to run the
test locally.

What:
- Added unittest to run all tests on all open-source projects.
- Updated gitignore to ignore tmp folders of FOSS projects.
- Blocked pytest from finding tests in the cloned projects.

Addresses:
Depends on:
#43

Addresses:
#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI 📦 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants