-
Notifications
You must be signed in to change notification settings - Fork 3
Add a single foss project to test rules on in ci #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58c6949 to
1aaea19
Compare
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this is ripe for rebase.
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great start!
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this looks great. How do the followup patches look like? A python-style unit test? Is that was #16 is supposed to do?
Szelethus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Its pretty troublesome to review the other patches with this initial one not being in, and I don't see what else we could change on this. Lets push it!
Why: We want to test on open source projects. We want to be able to run the test locally. What: - Added unittest to run all tests on all open-source projects. - Updated gitignore to ignore tmp folders of FOSS projects. - Blocked pytest from finding tests in the cloned projects. Addresses: Depends on: #43 Addresses: #20
Why: We want to test our rules on real-world examples
What: Added a single FOSS project to the CI pipeline
see issue: #20
Note:
The goal is to build a robust test suite in small steps.
Depends on:
#62