Re-enable 'unknown types and functions' warnings and update CI #153
+42
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Nov 21, 2025
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Use a rebar3 versions that matches OTP 27 and 28 Signed-off-by: Björn Svensson <[email protected]>
rebar3 seems to have changed so its shell only runs in interactive mode, which Github Actions TTY does not support and halts without running. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Nov 21, 2025
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
OK, then, since rebar3 as test dialyzer seems to work with the workaround, I suppose we can merge this as is.
Should we preserve the individual commits or squash them?
bjosv
changed the title
Collaborator
Author
I have updated the PR header now. Squashing them is fine with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the
unknown function or typewarning that previously was disabled for handling OTP 26.Additional apps are needed in the PLT and added via
plt_extra_appsto handle the previously hidden warnings, like:This PR also updates the CI:
releaseCI job, which now useserlinstead ofrebar3 shell.rebar3 seems to have changed so its shell only runs in interactive mode, but Github Actions don't support TTYs and halts without running.