Remove use of deprecated gen_server callback format_status/2
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback `format_status(Opt, StatusData)` is deprecated from OTP 27 and give build warnings. Remove them since they are optional and no-op's in our case. Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Nov 1, 2024
|
Good idea. Should we release it in a patch version? It's not a documented part of the API, so it's not really a breaking change. Just fix a build issue, which can be OK for a patch release? |
|
I also think we could include it in a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback
format_status(Opt, StatusData)is deprecated from OTP 27 and give build warnings.Removing them since they are optional and no-op's in our case.
https://www.erlang.org/doc/apps/stdlib/gen_server.html#c:format_status/2