-
-
Notifications
You must be signed in to change notification settings - Fork 322
Add Korean translation #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean translation #2403
Conversation
feat: scaffold basic translation template feat: add project translation feat: add translation for SharedLocale feat: add translation for ModelAnalyzerLocale Modify package name Add Korean translation feat: add partial translation for ReverseEngineerLocale 'Loading' Unify translation feat: add partial translation for ReverseEngineerLocale feat: add rest of translation for ReverseEngineerLocale fix: add missing translation
Apparently, there's another translation contribution for the Korean language (timing was sharp): #2404 Maybe we/he can merge the translations into one PR, possibly with cross-checking and choosing better words for expression? |
@preco21 Please coordinate with the other PR if possible? |
Just reviewed your translation, and it looks great overall! There are just a few quirks in the terminology used for the CompareLocale.ko.resx file. Sticking with my translations for that specific file might ensure everything aligns perfectly. |
@ErikEJ Sure, I will review the other competing PRs and reach out to the authors to see if we can merge their work into this PR. |
@domicmeia Hi, thank you for your review! I appreciate your feedback and the work you've put into the translations. We'll incorporate your translations for the |
Ref ErikEJ#2404 Co-Authored-By: domicmeia <[email protected]>
So this PR is ready for my review and merge now? |
@ErikEJ Hi, I just asked the author of the other PR for the last piece of the puzzle. If he's willing to participate in this PR, it might be best to wait for another day at this moment. (KST?) Or alternatively, you can review and merge this PR and ask them to add subsequent PRs for further improvements. :) |
I will wait, no rush! |
@LocketGoma Hi, this PR includes all entries that needed to be translated up to this commit: bdffceb. It might be missing some entries if there have been updates after this point. We would greatly appreciate it if you could review the changes in this PR, particularly for any quirks or unsound translations. I'm not sure if anyone have a permission to leave a code review for any PR like this, please use GitHub's code review feature and let me know if it doesn't work. |
Got it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Witten by Korean)
일부 어색한 표현 수정 제안 드렸습니다.
@LocketGoma 감사합니다! Thanks! |
Co-Authored-By: LocketGoma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인 완료
Hi @utilForever, anything you would like to add or review changes before finalizing? Ref: #2405 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check my comments? Thanks.
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
Co-authored-by: Chris Ohk <[email protected]>
@utilForever Thank you for your thoughtful review! I have incorporated your suggestions and left some comments where I would like to discuss further. Once all these ongoing conversations are resolved, I will notify the owner that the PR is ready. |
Hi @ErikEJ, it's a bit late though 😅, I didn't expect that so many people to get involved and help us out. I really appreciate for everyone's participation. The PR is now ready to go. Thanks. @KOZ39 @domicmeia @LocketGoma @utilForever 감사합니다!! 👍 |
@preco21 Thanks, what an amazing community effort! This extension is now localized in all available Visual Studio languages! |
I really appreciate everyone involved into this Korean localisation. I'm really glad and proud to be witnessing this collaboration. Thanks @ErikEJ for providing this awesome tool, and |
This is the initial Korean translation for this project.
We discovered your post on X seeking someone to translate this project in Korean. Although we have no experience with EFCore, we noticed that the issue has been open for almost four months, awaiting a Korean translation.
Therefore, we decided to contribute by providing this initial translation.
Please note that this is a rough translation, and you may want to request other Korean speakers to review it.
#2034