Skip to content

Commit 063fb47

Browse files
committed
feat: disable navdrawer separator feature
1 parent c975c87 commit 063fb47

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

internal/widget/navdrawer.go

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ type navItemVariant uint
2424
const (
2525
navUndefined navItemVariant = iota
2626
navPage
27-
navSectionLabel
27+
navSectionLabel // TODO: Maybe remove when no longer used?
2828
navSeparator
2929
)
3030

@@ -70,8 +70,7 @@ func (w *NavDrawer) ScrollToTop() {
7070

7171
func (w *NavDrawer) makeList() *widget.List {
7272
p := w.Theme().Size(theme.SizeNamePadding)
73-
var list *widget.List
74-
list = widget.NewList(
73+
list := widget.NewList(
7574
func() int {
7675
return len(w.items)
7776
},
@@ -174,10 +173,10 @@ func (w *NavDrawer) makeList() *widget.List {
174173
spacer.Hide()
175174
updateBadge()
176175
}
177-
fyne.Do(func() {
178-
// TODO: Maybe remove?
179-
list.SetItemHeight(id, co.(*fyne.Container).MinSize().Height) // needed for separators
180-
})
176+
// fyne.Do(func() {
177+
// // TODO: Maybe remove?
178+
// list.SetItemHeight(id, co.(*fyne.Container).MinSize().Height) // needed for separators
179+
// })
181180
},
182181
)
183182
list.OnSelected = func(id widget.ListItemID) {
@@ -337,9 +336,9 @@ func NewNavSectionLabel(text string) *NavItem {
337336
return it
338337
}
339338

340-
func NewNavSeparator() *NavItem {
341-
return newNavItem(navSeparator)
342-
}
339+
// func NewNavSeparator() *NavItem {
340+
// return newNavItem(navSeparator)
341+
// }
343342

344343
func newNavItem(variant navItemVariant) *NavItem {
345344
it := &NavItem{

internal/widget/navdrawer_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func TestNavDrawer_CanCreateFull(t *testing.T) {
3333
drawer := iwidget.NewNavDrawer(
3434
iwidget.NewNavPage("First", theme.HomeIcon(), widget.NewLabel("PLACEHOLDER 1")),
3535
iwidget.NewNavPage("Second", theme.HomeIcon(), widget.NewLabel("PLACEHOLDER 2")),
36-
iwidget.NewNavSeparator(),
36+
// iwidget.NewNavSeparator(),
3737
iwidget.NewNavPage("Third", theme.HomeIcon(), widget.NewLabel("PLACEHOLDER 3")),
3838
iwidget.NewNavSectionLabel("Section"),
3939
iwidget.NewNavPage("Forth", theme.HomeIcon(), widget.NewLabel("PLACEHOLDER 4")),
-4 Bytes
Loading

0 commit comments

Comments
 (0)