Feature: armor, protection, resistance damage types (Issue: #3)#4
Open
rx-dev wants to merge 2 commits intoErrorCraft:masterfrom
Open
Feature: armor, protection, resistance damage types (Issue: #3)#4rx-dev wants to merge 2 commits intoErrorCraft:masterfrom
rx-dev wants to merge 2 commits intoErrorCraft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 3 new api functions
apply/armor-> applies normal damage that respects armor (like melee attacks)apply/projectile-> applies projectile damage (proj protection, etc)apply/explosion-> applies explosive damage (blast protection)Armor, armor toughness, resistance, and protection are all accounted for
for projectiles and explosions, proj protection and blast protection are accounted for
I've done some testing and the only inconsistencies are half a heart off due to rounding (since score based damage doesn't utilize scale for precision). This system will always truncate instead of rounding which can easily be changed.
See Issue #3 for more info.