Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is an issue in the instanceof check.
I keep getting an warning message like this in my bundler where imported this library:
Right now
!inputRef.current
is evaluated first to eithertrue
orfalse
, andtrue instanceof HTMLInputElement
andfalse instanceof HTMLInputElement
would both evaluate tofalse
, so I think this code will not trigger at all at the moment.For extra confirmation I tried plugging it into ASTExplorer which also showed that
!inputRef.current
is evaluated as one unit:I just created this PR in the GitHub web interface, not sure if that will suffice to be ready to merge. Let me know if you'd need anything from me. Thanks!