Basic filtering of deleted files #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as we call out to `git diff` to get the list of files to process, we can add a `—diff-filter` argument that ignores deleted. This will allow us to skip running our hooks on files that no longer exist. There was some confusion on the last PR as I used the wrong account.
ghost
mentioned this pull request
|
Hello ! Thanks for your contribution :) looks good to me |
arthurio
suggested changes
Jun 25, 2024
arthurio
suggested changes
Jun 25, 2024
arthurio
suggested changes
Jun 25, 2024
|
@jfb-workhelix Can we get things going? I made https://github.com/jfb-workhelix/mookme/pull/1 to add some tests on top of your changes. |
Add tests for filtering out deleted files
|
Happy to pull it in and run it. |
|
OK, it's merged in here, and the tests do complete successfully! Should I open a new PR? |
arthurio
approved these changes
Jul 15, 2024
It's up to @LMaxence now, but I don't think it needs a new PR. |
|
It's fine by me :) Thanks for your contribution ! |
|
Version 2.5.1 features your change :) Thanks again ! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as we call out to
git diffto get the list of files to process, we can add a—diff-filterargument that ignores deleted. This will allow us to skip running our hooks on files that no longer exist.There was some confusion on the last PR as I used the wrong account.