Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManageFeatures rework #1294

Merged
merged 2 commits into from
Sep 20, 2023
Merged

ManageFeatures rework #1294

merged 2 commits into from
Sep 20, 2023

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Sep 16, 2023

Description

This PR aims at restructuring the code for increased readability.

  • Bug fix: Delete features button wasn't appearing on MAUI
  • Organize code into regions, chronological
  • Modify and remove some helper methods
  • Updates readme with operation-specific instructions
  • Minor UI tweaks
  • Some variable renames
  • Code style

I apologize for the large git diff.

Type of change

  • Bug fix
  • Other enhancement

Platforms tested on

  • WPF .NET 6
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3
Copy link
Collaborator Author

williambohrmann3 commented Sep 16, 2023

A note about changing the orders of some of the methods, this was my methodology:

  1. Constructer
  2. Initialize
  3. Feature management operations organized into 3 regions (Create is one function only)
  4. Other event handlers
  5. Helper method

Again, I apologize for the git diff, I hope this organization makes the code slightly more readable.

@williambohrmann3 williambohrmann3 marked this pull request as ready for review September 16, 2023 01:01
@williambohrmann3 williambohrmann3 self-assigned this Sep 16, 2023
Copy link
Collaborator

@duffh duffh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@williambohrmann3 williambohrmann3 merged commit 389f43b into main Sep 20, 2023
6 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/ManageFeatures-rework branch September 20, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants