Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayDeviceLocation rework #1296

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Sep 20, 2023

Description

The aim of this PR is to improve the sample based on lessons learned when writing the corresponding tutorial.

  • Adds detailed comments
  • MAUI: only subscribe to LocationDisplay.AutoPanModeChanged event once
  • Standardizes basemaps on all samples
  • Defaults to auto pan mode off in combo box when first loading sample
  • Start and stop the location data source for better error handling and more accurate button text
  • Updates screenshots

Type of change

  • Bug fix

Platforms tested on

  • WPF .NET 6
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3 williambohrmann3 marked this pull request as ready for review September 21, 2023 00:27
@williambohrmann3 williambohrmann3 merged commit 20f1e02 into main Sep 21, 2023
@williambohrmann3 williambohrmann3 deleted the wbohr/DisplayDeviceLocation-PermissionStatus branch September 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants