Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphicsOverlay MAUI samples: layout changes #1315

Closed
wants to merge 8 commits into from

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Nov 2, 2023

Description

Ensures MAUI samples in GraphicsOverlay category can be resized on phone, tablet, and PC. Also accounts for device orientation changes by utilizing TwoPaneView. Opted for v.next as to take advantage of fixes brought in from .NET 8.

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3
Copy link
Collaborator Author

Planning on getting screenshots taken after we've agreed on UI.

@williambohrmann3 williambohrmann3 marked this pull request as ready for review November 3, 2023 00:06
@williambohrmann3
Copy link
Collaborator Author

cc: @cgutierrez-gis

@williambohrmann3
Copy link
Collaborator Author

Closing for now - attempting to fix our sample geoview, border, and grid styles to allow for device orientation changes on iOS.

@williambohrmann3 williambohrmann3 deleted the wbohr/GraphicsOverlay-MAUI branch December 15, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant