Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET MAUI samples: float button #1322

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Nov 27, 2023

Description

For samples which have (or start with) one single button, float the button over the GeoView. This simplifies the XAML, eliminates unneeded borders, and reduces DynamicResources.

Type of change

  • Sample viewer enhancement

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3 williambohrmann3 self-assigned this Nov 27, 2023
@williambohrmann3 williambohrmann3 marked this pull request as ready for review December 1, 2023 23:53
@williambohrmann3
Copy link
Collaborator Author

Before:
Xamarin Simulator Windows_GwQ59NYvc6

After:
Xamarin Simulator Windows_wOMQb6a9Am

@pMaske
Copy link
Member

pMaske commented Dec 6, 2023

@williambohrmann3 how does this look in portrait mode?

@williambohrmann3
Copy link
Collaborator Author

@pMaske the same as landscape - button in top right corner.

@williambohrmann3 williambohrmann3 merged commit 9acad27 into v.next Dec 11, 2023
2 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/maui-float-buttons branch December 11, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants