Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET MAUI Animate3dGraphic: use ScrollView #1328

Merged
merged 2 commits into from
Dec 11, 2023
Merged

.NET MAUI Animate3dGraphic: use ScrollView #1328

merged 2 commits into from
Dec 11, 2023

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Dec 1, 2023 •
edited
Loading

Description

There is an issue with buttons not fitting in the control panel. This PR encourages a scrollable, vertical layout to prevent future UI issues relating to width.

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3 williambohrmann3 self-assigned this Dec 1, 2023
@williambohrmann3 williambohrmann3 changed the title Animate3dGraphic MAUI - use ScrollView .NET MAUI Animate3dGraphic MAUI: use ScrollView Dec 1, 2023
@williambohrmann3 williambohrmann3 changed the title .NET MAUI Animate3dGraphic MAUI: use ScrollView .NET MAUI Animate3dGraphic: use ScrollView Dec 2, 2023
@williambohrmann3 williambohrmann3 marked this pull request as ready for review December 4, 2023 22:43
@williambohrmann3
Copy link
Collaborator Author

Before:
Screenshot 2023-12-05 at 10 06 15 AM

After:
Screenshot 2023-12-05 at 10 09 22 AM

@williambohrmann3 williambohrmann3 merged commit 1715fed into v.next Dec 11, 2023
2 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/Animate3dGraphics-MAUI-ScrollView branch December 11, 2023 17:21
williambohrmann3 added a commit that referenced this pull request Dec 14, 2023
@williambohrmann3
.NET MAUI Animate3dGraphic: use ScrollView (#1328)
1e953b4
@williambohrmann3 williambohrmann3 mentioned this pull request Dec 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duffh duffh duffh approved these changes

@cgutierrez-gis cgutierrez-gis Awaiting requested review from cgutierrez-gis

Assignees

@williambohrmann3 williambohrmann3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williambohrmann3 @duffh