Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddClusteringFeatureReductionToAPointFeatureLayer: Unchecked event subscription #1330

Merged
merged 1 commit into from
Dec 1, 2023
Merged

AddClusteringFeatureReductionToAPointFeatureLayer: Unchecked event subscription #1330

merged 1 commit into from
Dec 1, 2023

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Dec 1, 2023 •
edited
Loading

Description

Subscribe to the unchecked event for the display label checkbox for WPF and WinUI implementations of AddClusteringFeatureReduction. Not in issue for .NET MAUI implementation since we're subscribed to the CheckedChanged event.

Type of change

  • Bug fix

Platforms tested on

  • WPF .NET 6
  • WPF Framework
  • WinUI

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

@williambohrmann3 williambohrmann3 self-assigned this Dec 1, 2023
@williambohrmann3 williambohrmann3 marked this pull request as ready for review December 1, 2023 02:43
@williambohrmann3
Copy link
Collaborator Author

cc: @pMaske

@williambohrmann3 williambohrmann3 changed the title AddClusteringFeatureReduction: Unchecked event subscription AddClusteringFeatureReductionToAPointFeatureLayer: Unchecked event subscription Dec 1, 2023
duffh
duffh approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@duffh duffh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@williambohrmann3 williambohrmann3 merged commit e87d862 into v.next Dec 1, 2023
2 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/AddClusteringFeatureReductionToAPointFeatureLayer-Unchecked branch December 1, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duffh duffh duffh approved these changes

Assignees

@williambohrmann3 williambohrmann3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williambohrmann3 @duffh