-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sample: Snap geometry edits #1442
Conversation
Reviewers please review files in Geometry/SnapGeometryEdits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent sample. UI looks fantastic. Tested on WPF and MAUI Android (landscape works as well 😃), everything seems to be functioning correctly. My feedback is focused on comments which applies to all implementations.
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Geometry/SnapGeometryEdits/readme.md
Outdated
Show resolved
Hide resolved
src/WinUI/ArcGIS.WinUI.Viewer/Samples/Geometry/SnapGeometryEdits/SnapGeometryEdits.xaml.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @duffh! I was able to test it with the .NET sample viewer. I've left some minor comments. Thanks!
Description
Implemented new sample to demonstrate how to use the Geometry Editor to edit a geometry and align it to existing geometries on a map.
Updated the sample sync python script to generate proper redirects, this has caused a number of readme changes to be changed which are not directly relevant to the sample code.
Type of change
Platforms tested on
Checklist