Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAUI viewer UI enhancements #1464

Merged
merged 3 commits into from
Jul 1, 2024
Merged

MAUI viewer UI enhancements #1464

merged 3 commits into from
Jul 1, 2024

Conversation

williambohrmann3
Copy link
Collaborator

Description

  • Moves issue links from feedback button to vertical handle on sample page (mobile platforms). dc61966
  • Updates app shell styling. 0fefcd6

Comparison

left before, right after

Vertical handle

before after

Flyout

before after

Type of change

  • Bug fix
  • Sample viewer enhancement

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • No unrelated changes have been made to any other code or project files

On the sample page, removes the feedback button to provide more room for the title. Moves the GitHub links into the existing vertical handle. Exposes static methods on the feedback prompt for opening issue links.
Uses official purple shade across app. Ensures flyout title is legible and visible on all platforms. Uses a black highlight for category selected for consistency (this was orange by default on Android, semi-transparent on Windows, and grey on MacCatalyst).
@williambohrmann3 williambohrmann3 self-assigned this Jun 27, 2024
@williambohrmann3 williambohrmann3 requested a review from duffh June 27, 2024 21:02
@williambohrmann3 williambohrmann3 merged commit ceb06b7 into main Jul 1, 2024
6 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/maui-viewer-shell branch July 1, 2024 16:02
williambohrmann3 added a commit that referenced this pull request Jul 1, 2024
williambohrmann3 added a commit that referenced this pull request Jul 3, 2024
williambohrmann3 added a commit that referenced this pull request Jul 8, 2024
williambohrmann3 added a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants