Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Key updates #1471

Merged
merged 2 commits into from
Jul 15, 2024
Merged

API Key updates #1471

merged 2 commits into from
Jul 15, 2024

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Jul 9, 2024

Description

Update links to obtain an API key.

Type of change

  • Other enhancement

@duffh duffh requested review from pMaske and ThadT July 9, 2024 14:46
maryharvey
maryharvey suggested changes Jul 9, 2024
View reviewed changes
Copy link

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duffh @ThadT I have made some suggestions to the text. Perhaps all this information is not required... it depends what you have included in the Readme. Thanks

src/Samples.Shared/Managers/ApiKeyManager.cs Outdated Show resolved Hide resolved
src/WPF/WPF.Viewer/ApiKeyPrompt.xaml Outdated Show resolved Hide resolved
src/WinUI/ArcGIS.WinUI.Viewer/ApiKeyPrompt.xaml Outdated Show resolved Hide resolved
@duffh duffh requested a review from maryharvey July 11, 2024 16:31
maryharvey
maryharvey suggested changes Jul 11, 2024
View reviewed changes
Copy link

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duffh Thanks for this - one comment here

src/MAUI/Maui.Samples/Views/ApiKeyView.xaml Show resolved Hide resolved
@duffh duffh requested a review from maryharvey July 12, 2024 14:07
maryharvey
maryharvey approved these changes Jul 15, 2024
View reviewed changes
Copy link

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duffh looks good thanks

@duffh duffh merged commit 97a6986 into main Jul 15, 2024
6 checks passed
@duffh duffh deleted the hduff/update-api-key-links branch July 15, 2024 10:01
github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
@duffh @arcgis-maps-sdk-bot
API Key updates (#1471)
d8c7419
@pMaske
Copy link
Member

pMaske commented Jul 18, 2024

@duffh probably should also update the readme. There is a small note on API key in the readme section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryharvey maryharvey maryharvey approved these changes

@pMaske pMaske Awaiting requested review from pMaske

@ThadT ThadT Awaiting requested review from ThadT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duffh @pMaske @maryharvey