Skip to content

Update Show magnifier sample readme to correctly reflect API functionality #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Jul 12, 2024

Description

Updated Show magnifier sample to demonstrate correct usage of mapView.MapViewInteractionOptions.IsMagnifierEnable and the default property to be true.

Type of change

  • Other enhancement

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@duffh duffh requested a review from williambohrmann3 July 12, 2024 18:41
@duffh duffh self-assigned this Jul 12, 2024
Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, approving pending readme style check resolution (they need end of line characters)

@duffh duffh merged commit 39005ea into main Jul 15, 2024
6 checks passed
@duffh duffh deleted the hduff/ShowMagnifier-sample-update branch July 15, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants