Skip to content

Updating ReadMe About the data section #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

cgutierrez-gis
Copy link
Collaborator

@cgutierrez-gis cgutierrez-gis commented May 30, 2025

Description

This PR is for WMS service catalog in Layers category. Fix wrong data description in the "About the data" section. The data link was swapped but the description fell stale.

Type of change

  • Sample viewer enhancement

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@cgutierrez-gis
Copy link
Collaborator Author

@wil13058 Should I also rename this sample to how it is on the design repo as "Browse WMS layers"? Seems a bit too similar to a sample we have named "Browse WFS layers" though.

@williambohrmann3
Copy link
Collaborator

@cgutierrez-gis let's get this change in first, you can always spin up a sample rename PR later

@cgutierrez-gis
Copy link
Collaborator Author

@williambohrmann3 got it thanks. 👍

@cgutierrez-gis cgutierrez-gis merged commit 8bc6675 into main Jun 2, 2025
5 of 6 checks passed
@cgutierrez-gis cgutierrez-gis deleted the Carlos/BrowseWMSLayersReadMe branch June 2, 2025 23:38
github-actions bot pushed a commit that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants