Skip to content

Readme redirect corrections #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cgutierrez-gis
Copy link
Collaborator

Description

Due to redirect link requirements it seems like there are some things that need to be corrected in terms of which links are needed by the public samples. There are corrections that need to be made by the public samples that have recently been renamed, consolidated, or recently added to meet the requirements.

Type of change

  • Bug fix

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@@ -18,8 +18,10 @@
"offline_data": [
"68ec42517cdd439e81b036210483e8e7"
],
"redirect_from": [
"/net/latest/maui/sample-code/add-rasters-and-feature-tables-from-geopackage.htm"
"redirect_from": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 4 space indent; I see wrong indent in several places in this PR

"/net/latest/maui/sample-code/query-related-features-from-non-spatial-table.htm"
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo space diff here

@@ -29,6 +29,11 @@
],
"offline_data": [],
"redirect_from": [
"/net/latest/wpf/sample-code/manage-features.htm",
"/nett/latest/wpf/sample-code/add-features.htm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: nett

@cgutierrez-gis
Copy link
Collaborator Author

@williambohrmann3 indentations resolved. Should be good to go 👍

@@ -29,6 +29,11 @@
],
"offline_data": [],
"redirect_from": [
"/net/latest/wpf/sample-code/manage-features.htm",
"/net/latest/wpf/sample-code/add-features.htm",
"/nett/latest/wpf/sample-code/delete-features.htm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/nett/latest/wpf/sample-code/delete-features.htm",
"/net/latest/wpf/sample-code/delete-features.htm",

"/net/latest/wpf/sample-code/manage-features.htm",
"/net/latest/wpf/sample-code/add-features.htm",
"/nett/latest/wpf/sample-code/delete-features.htm",
"/nett/latest/wpf/sample-code/update-attributes.htm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/nett/latest/wpf/sample-code/update-attributes.htm",
"/net/latest/wpf/sample-code/update-attributes.htm",

"/net/latest/wpf/sample-code/add-features.htm",
"/nett/latest/wpf/sample-code/delete-features.htm",
"/nett/latest/wpf/sample-code/update-attributes.htm",
"/nett/latest/wpf/sample-code/update-geometries.htm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/nett/latest/wpf/sample-code/update-geometries.htm",
"/net/latest/wpf/sample-code/update-geometries.htm",

@@ -13,8 +13,10 @@
"search"
],
"offline_data": [],
"redirect_from": [
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"
"redirect_from": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"redirect_from": [
"redirect_from": [

"redirect_from": [
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"
"redirect_from": [
"/net/wpf/sample-code/map-image-layer-tables.htm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/net/wpf/sample-code/map-image-layer-tables.htm",
"/net/wpf/sample-code/map-image-layer-tables.htm",

"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"
"redirect_from": [
"/net/wpf/sample-code/map-image-layer-tables.htm",
"/net/latest/wpf/sample-code/map-image-layer-tables.htm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/net/latest/wpf/sample-code/map-image-layer-tables.htm",
"/net/latest/wpf/sample-code/map-image-layer-tables.htm",

"redirect_from": [
"/net/wpf/sample-code/map-image-layer-tables.htm",
"/net/latest/wpf/sample-code/map-image-layer-tables.htm",
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"

"redirect_from": [
"/net/wpf/sample-code/map-image-layer-tables.htm",
"/net/latest/wpf/sample-code/map-image-layer-tables.htm",
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm"
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
],
],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants