-
Notifications
You must be signed in to change notification settings - Fork 523
Readme redirect corrections #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -18,8 +18,10 @@ | |||
"offline_data": [ | |||
"68ec42517cdd439e81b036210483e8e7" | |||
], | |||
"redirect_from": [ | |||
"/net/latest/maui/sample-code/add-rasters-and-feature-tables-from-geopackage.htm" | |||
"redirect_from": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use 4 space indent; I see wrong indent in several places in this PR
"/net/latest/maui/sample-code/query-related-features-from-non-spatial-table.htm" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo space diff here
@@ -29,6 +29,11 @@ | |||
], | |||
"offline_data": [], | |||
"redirect_from": [ | |||
"/net/latest/wpf/sample-code/manage-features.htm", | |||
"/nett/latest/wpf/sample-code/add-features.htm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: nett
@williambohrmann3 indentations resolved. Should be good to go 👍 |
@@ -29,6 +29,11 @@ | |||
], | |||
"offline_data": [], | |||
"redirect_from": [ | |||
"/net/latest/wpf/sample-code/manage-features.htm", | |||
"/net/latest/wpf/sample-code/add-features.htm", | |||
"/nett/latest/wpf/sample-code/delete-features.htm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/nett/latest/wpf/sample-code/delete-features.htm", | |
"/net/latest/wpf/sample-code/delete-features.htm", |
"/net/latest/wpf/sample-code/manage-features.htm", | ||
"/net/latest/wpf/sample-code/add-features.htm", | ||
"/nett/latest/wpf/sample-code/delete-features.htm", | ||
"/nett/latest/wpf/sample-code/update-attributes.htm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/nett/latest/wpf/sample-code/update-attributes.htm", | |
"/net/latest/wpf/sample-code/update-attributes.htm", |
"/net/latest/wpf/sample-code/add-features.htm", | ||
"/nett/latest/wpf/sample-code/delete-features.htm", | ||
"/nett/latest/wpf/sample-code/update-attributes.htm", | ||
"/nett/latest/wpf/sample-code/update-geometries.htm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/nett/latest/wpf/sample-code/update-geometries.htm", | |
"/net/latest/wpf/sample-code/update-geometries.htm", |
@@ -13,8 +13,10 @@ | |||
"search" | |||
], | |||
"offline_data": [], | |||
"redirect_from": [ | |||
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" | |||
"redirect_from": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"redirect_from": [ | |
"redirect_from": [ |
"redirect_from": [ | ||
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" | ||
"redirect_from": [ | ||
"/net/wpf/sample-code/map-image-layer-tables.htm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/net/wpf/sample-code/map-image-layer-tables.htm", | |
"/net/wpf/sample-code/map-image-layer-tables.htm", |
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" | ||
"redirect_from": [ | ||
"/net/wpf/sample-code/map-image-layer-tables.htm", | ||
"/net/latest/wpf/sample-code/map-image-layer-tables.htm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/net/latest/wpf/sample-code/map-image-layer-tables.htm", | |
"/net/latest/wpf/sample-code/map-image-layer-tables.htm", |
"redirect_from": [ | ||
"/net/wpf/sample-code/map-image-layer-tables.htm", | ||
"/net/latest/wpf/sample-code/map-image-layer-tables.htm", | ||
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" | |
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" |
"redirect_from": [ | ||
"/net/wpf/sample-code/map-image-layer-tables.htm", | ||
"/net/latest/wpf/sample-code/map-image-layer-tables.htm", | ||
"/net/latest/wpf/sample-code/query-related-features-from-non-spatial-table.htm" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
], | |
], |
Description
Due to redirect link requirements it seems like there are some things that need to be corrected in terms of which links are needed by the public samples. There are corrections that need to be made by the public samples that have recently been renamed, consolidated, or recently added to meet the requirements.
Type of change
Platforms tested on
Checklist