WinUI: Add AoT support to BasemapGallery, BookmarksView, FloorFilter, OverviewMap and Legend #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile WinUI with AoT support
Use relative source or code-behind whenever possible
… WinUI (#620) * Rewrites several parts of the SearchView to make it AoT compatible in WinUI
* Add support for built-in iOS barcode scanner * Add Windows support to barcode scanner
* Adding barcode scanner to Android
Improves scanner launch time from ~40s to 1-2s due to a poor/ineffecient device selector string.
…in the dependent version minimums
* Add 3D Basemap Gallery support in WPF and BasemapGalleryItem * Add 3D basemap support to BasemapGallery in UWP, WinUI and MAUI Changed 3D basemap identification from Enum to boolean for simplified binding * Added condition to check if `GeoModel` is a `Scene` before fetching 3D basemaps * Renamed `BasemapGallery3DAppearanceSample` to `BasemapGallerySceneViewAppearanceSample`. * Consolidated Basemap fetching methods * Refactor BasemapGalleryItem to dynamically determine Is3D * Refactored 3D tag in BasemapGallery to sta on top right corner of the image in Grid View. * Introduce caching for basemaps in BasemapGalleryController * Update src/Toolkit/Toolkit.WinUI/Esri.ArcGISRuntime.Toolkit.WinUI.csproj * Update bindings to use static lambdas for type safety as new feature from .Net 9 * Reverted binding style for private set properties * Revert Margin in Basemap Gallery Item * Fixing bug in BasemapGallery loading * Restore styling for basemapgallery * Refactor basemap loading to be fully asynchronous * Refactor basemap loading and update visibility handling * Update BasemapGallery itemTypeBorder to theme-based color * Add one-way binding to fix the width sldier in WinUI and UWP and error handling improvements * Refactor loading state handling in BasemapGalleryController * Refactor basemap update logic in BasemapGallery * Enhance theme management in BasemapGallery
Several controls are still not AoT compatible
* Enhance basemap loading with async task management caching - Introduces Task caching mechanism to manage asynchronous loading of basemap gallery items. - Updates `LoadBasemapGalleryItems` to check for ongoing tasks, preventing multiple concurrent loads. * Refactor basemap loading and portal change handling * Refactor basemap handling on portal changes. Restored `HandlePortalChanged` to manage portal changed event including cache invalidation and asynchronous basemap updates. Added invalidating of cache on `AvailableBasemaps` assigned manually.
# Conflicts: # src/Samples/Toolkit.SampleApp.WinUI/Toolkit.SampleApp.WinUI.csproj
dotMorten
changed the title
dotMorten
changed the title
dotMorten
changed the title
dotMorten
changed the title
dotMorten
changed the title
mstefarov
reviewed
Apr 16, 2025
src/Toolkit/Toolkit.WinUI/UI/Controls/BasemapGallery/BasemapGallery.Theme.xaml
Outdated
Show resolved
Hide resolved
src/Toolkit/Toolkit.WinUI/UI/Controls/BookmarksView/BookmarksView.Theme.xaml
Outdated
Show resolved
Hide resolved
mstefarov
reviewed
Apr 16, 2025
prathameshnarkhede
approved these changes
Apr 16, 2025
mstefarov
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds WinUI AoT support to: