-
Notifications
You must be signed in to change notification settings - Fork 126
New FileDownloadTask helper #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions. Otherwise, Looks good!
Also, Recently I read about SemaphoreSlim
and seems this could be a good candidate for its usage.
src/Samples/Toolkit.SampleApp.UWP/Samples/Downloading/FileDownloadSample.xaml
Show resolved
Hide resolved
src/Samples/Toolkit.SampleApp.WPF/Samples/Downloading/DownloadItemVM.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Matvei Stefarov <[email protected]>
…DownloadAsync() since it can be problematic to wait for a task that might never resume, and it was still quite broken, since a paused task would complete.
…sn't interrupted/corrupted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nitpick, and it'll be good to go 👍
Sample app:
FileDownloader.mp4
API:
