Skip to content

New FileDownloadTask helper #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2025
Merged

New FileDownloadTask helper #650

merged 7 commits into from
Jun 11, 2025

Conversation

dotMorten
Copy link
Member

@dotMorten dotMorten commented May 29, 2025

Sample app:

FileDownloader.mp4

API:
image

@dotMorten dotMorten self-assigned this May 29, 2025
Copy link
Contributor

@prathameshnarkhede prathameshnarkhede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions. Otherwise, Looks good!

Also, Recently I read about SemaphoreSlim and seems this could be a good candidate for its usage.

dotMorten and others added 3 commits June 3, 2025 09:05
…DownloadAsync() since it can be problematic to wait for a task that might never resume, and it was still quite broken, since a paused task would complete.
@dotMorten dotMorten requested a review from mstefarov June 3, 2025 16:24
@dotMorten dotMorten requested a review from mstefarov June 9, 2025 22:20
Copy link
Collaborator

@mstefarov mstefarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick, and it'll be good to go 👍

@dotMorten dotMorten merged commit 94b724b into main Jun 11, 2025
1 check passed
@dotMorten dotMorten deleted the downloadtask branch June 11, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants