-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(arcgis-rest-request): node ReadStream encoding bug at 3.x #1034
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @haoliangyu
I think when this is merged it will trigger a 3.x patch release, but I'm not certain. Let's wait until @dbouwman confirms before merging.
For rest-js v3, we did not have semantic-release, so you actually want to PR this to This PR is the last time we did a 3.x release. I can run the scripts if you want. Just lmk via teams once this is merged. |
Thanks @dbouwman, yeah, I just noticed that we don't have a .releaserc.json file that I believe would be required to run the release on maintenance branches. I've updated the base, and will merge and run the scripts. |
@tomwayson Do you have any availability to release this as v3.5.1? |
@haoliangyu this has been published as v.3.5.1 |
This PR addresses the issue #1033 at rest-js v3. The bug is related to the form-data library in the node environment. It requires to use an unofficial option to specify the stream length so that the streaming request can end properly (see #1033 (comment)).
I add a
dataSize
option to theaddItemData()
function so that the user can give a number for the stream data length.PS: I suspect other functions accepting node ReadStream can have the same issue, but I don't have the availability to verify and fix each API.
PS2: I assume that no more than one stream is used in one API call.
PS3: I have to update the npm version to v7 in CI so that
npm install
won't throw an error.