Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): provide visual changes background #11264

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

geospatialem
Copy link
Member

Related Issue: #10967

Summary

Include a Visual changes section to supplement the Visual snapshots section within the CONTRIBUTING.md.

@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 10, 2025
@geospatialem geospatialem self-assigned this Jan 10, 2025
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Jan 10, 2025
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the change could provoke a visual test from passing...

Should this be "prevent" instead of provoke?

@geospatialem
Copy link
Member Author

If the change could provoke a visual test from passing...

Should this be "prevent" instead of provoke?

Updated 🚀

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@geospatialem geospatialem merged commit 83576a2 into dev Jan 13, 2025
11 checks passed
@geospatialem geospatialem deleted the geospatialem/10967-docs-visual-changes branch January 13, 2025 18:19
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #10967

## Summary
Include a `Visual changes` section to supplement the `Visual snapshots`
section within the CONTRIBUTING.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants